Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTC Out-of-tree JIT linkage failure #1154

Closed
henrytwo opened this issue Aug 4, 2022 · 0 comments
Closed

LTC Out-of-tree JIT linkage failure #1154

henrytwo opened this issue Aug 4, 2022 · 0 comments
Assignees
@henrytwo

Comments

@henrytwo
Copy link
Member

henrytwo commented Aug 4, 2022 •
edited
Loading

Currently LTC fails to build using the OOT CI config due to this linkage error: https://github.com/llvm/torch-mlir/runs/7549301528?check_suite_focus=true

Currently we work around this by setting TORCH_MLIR_ENABLE_LTC=OFF in cmake, which excludes LTC from compilation and generates a "fake" library in its place.

Additionally, the library type for TorchMLIRJITIRImporter is set to MODULE instead of SHARED. It looks like changing the module type to SHARED is the trigger for the aforementioned CI problems. However, we need this library to be SHARED in order to link with LTC.
This was referenced Aug 4, 2022
Closed
Open
@henrytwo henrytwo self-assigned this Aug 8, 2022
@henrytwo henrytwo mentioned this issue Aug 8, 2022
Merged
@henrytwo henrytwo closed this as completed Aug 8, 2022
@henrytwo henrytwo reopened this Aug 16, 2022
@henrytwo henrytwo mentioned this issue Aug 19, 2022
Merged
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this issue Oct 3, 2022
@tungld @AlexandreEichenberger
Update RunONNXModel.py (llvm#1154)
fb59d2c 
added option to save model and verify.

Signed-off-by: Tung D. Le <tungld@gmail.com>
Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrytwo henrytwo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henrytwo