Change to notifyMatchFailure #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emitError is intended for error cases and not match failures of patterns. notifyMatchFailure is intended where pattern reports reason for not matching. Op verification should also not happen inside patterns but as part of verify, so left some of those as is to keep this change small.
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
Jul 27, 2022
emitError is intended for error cases and not match failures of patterns. notifyMatchFailure is intended where pattern reports reason for not matching. Op verification should also not happen inside patterns but as part of verify/verification, but left ones that were obviously verification to emitError inside patterns to keep this change small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitError is intended for error cases and not match failures of
patterns. notifyMatchFailure is intended where pattern reports reason
for not matching.
Op verification should also not happen inside patterns but as part of
verify, so left some of those as is to keep this change small.