Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump llvm tag to 3580daa #1078

Merged
merged 1 commit into from
Jul 18, 2022
Merged

bump llvm tag to 3580daa #1078

merged 1 commit into from
Jul 18, 2022

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Jul 18, 2022

This patch makes some rudimentary changes to torch-mlir's use of MLIR
Python bindings to work with the most recent LLVM code. We can perhaps
do better by being more selective in what we link against, instead of
using MLIRPythonExtension.RegisterEverything.

@silvasean
Copy link
Contributor

Adding note for future self: https://discourse.llvm.org/t/psa-mlir-c-python-api-registration-overhaul/63873

When we want to trim the dependencies we can follow the instructions in that link.

@ashay
Copy link
Collaborator Author

ashay commented Jul 18, 2022

The RefBackend (e2e) tests fail with the error JIT session error: Symbols not found: [ _mlir_alloc ]. Am I missing some Python module to import?

@silvasean
Copy link
Contributor

Looks like that change got reverted upstream: llvm/llvm-project@d04c2b2

This patch makes some rudimentary changes to torch-mlir's use of MLIR
Python bindings to work with the most recent LLVM code.  We can perhaps
do better by being more selective in what we link against, instead of
using `MLIRPythonExtension.RegisterEverything`.
@ashay ashay changed the title bump llvm tag to 477c2c6 bump llvm tag to 3580daa Jul 18, 2022
@ashay ashay merged commit 7f08169 into llvm:main Jul 18, 2022
@ashay ashay deleted the ashay/update-llvm-tag branch July 18, 2022 23:49
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 27, 2022
This patch makes some rudimentary changes to torch-mlir's use of MLIR
Python bindings to work with the most recent LLVM code.  We can perhaps
do better by being more selective in what we link against, instead of
using `MLIRPythonExtension.RegisterEverything`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants