[MHLO] Support for dynamic shape in basic op conversion by introducing CHLO dialect #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyokwok
reviewed
Jul 29, 2022
Vremold
force-pushed
the
upstream-03-init-mhlo-basic-op-conversion-dynamic
branch
from
2ceaca5
to
b8b7d22
Compare
|
Ready for review @silvasean @powderluv @fortianyou |
added 4 commits
August 2, 2022 09:51
…g CHLO dialect Co-authored-by: Bairen Yi <yibairen.byron@bytedance.com> Co-authored-by: Jiawei Wu <xremold@gmail.com> Co-authored-by: Tianyou Guo <tianyou.gty@alibaba-inc.com> Co-authored-by: Xu Yan <yancey.yx@alibaba-inc.com> Co-authored-by: Ziheng Jiang <ziheng.jiang@bytedance.com>
Vremold
force-pushed
the
upstream-03-init-mhlo-basic-op-conversion-dynamic
branch
2 times, most recently
from
1b6ce47
to
24264e9
Compare
|
Merged. Thanks @Yancey1989 @ZihengJiang @fortianyou |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* disable simd for matmul when simdization dim is smaller than simd vector in MatMul operator Signed-off-by: Alexandre Eichenberger <alexe@us.ibm.com> Co-authored-by: Tung D. Le <tungld@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RFC #999
This is a revision of PR #1116 . The main change is switching to use CHLO dialect to support dynamic shape when lowering basic op to MHLO dialect.
Co-authored-by: Bairen Yi yibairen.byron@bytedance.com
Co-authored-by: Jiawei Wu xremold@gmail.com
Co-authored-by: Tianyou Guo tianyou.gty@alibaba-inc.com
Co-authored-by: Xu Yan yancey.yx@alibaba-inc.com
Co-authored-by: Ziheng Jiang ziheng.jiang@bytedance.com