Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: update tag to 061e0189 #1180

Merged
merged 1 commit into from
Aug 9, 2022
Merged

llvm: update tag to 061e0189 #1180

merged 1 commit into from
Aug 9, 2022

Conversation

ashay
Copy link
Collaborator

@ashay ashay commented Aug 8, 2022

Summary of changes:

 - Switch to C++17 (similar to https://reviews.llvm.org/D131348)
 - Update MHLO to build with LLVM commit hash 061e0189
 - Replace deprecated `hasValue()` and `getValue()` with `has_value()`
   and `value()` respectively (https://reviews.llvm.org/D131349)
 - Use `TypedAttr` (https://reviews.llvm.org/D130092)
 - Use updated assembly format of `mhlo.compare` op (commit
   d03ef01e70fbf9afd0fa1976fbb7ed31838929b3 in MHLO repo)
@silvasean
Copy link
Contributor

Wow, that's a rough integrate! Thanks for pushing this through!

@ashay ashay marked this pull request as ready for review August 9, 2022 02:16
@ashay ashay changed the title [do not review yet] llvm: update tag to 061e0189 llvm: update tag to 061e0189 Aug 9, 2022
@ashay ashay merged commit bb47c16 into llvm:main Aug 9, 2022
@ashay ashay deleted the ashay/llvm-tag-update branch August 9, 2022 03:17
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
…1180)

Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants