[MHLO]fix lowering failed on reduction op with i32 shape #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vremold
reviewed
Aug 9, 2022
Yancey1989
force-pushed
the
fix_reduction_i32_shape
branch
from
0f1fafd
to
fbf1e64
Compare
Vremold
approved these changes
Aug 9, 2022
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
- install onnx into lib instead of lib64 - fix time zone setup in container - download jsoniter jar from maven repo - run check-mlir on s390x but ignore error for now - run check-onnx-backend-signature - unshallow and rename origin to upstream for onnx-mlir-dev image to be published Signed-off-by: Gong Su <gong_su@hotmail.com> Co-authored-by: Alexandre Eichenberger <alexe@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed lowering failed on
ten::max_dimwith i32 shape type.