build: streamline options for enabling LTC and MHLO #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashay
changed the title
powderluv
reviewed
Aug 13, 2022
Prior to this patch, LTC was enabled by default, but it was disabled in setup.py and in the Github CI rules. MHLO, on the other hand, was enabled by default, but also (i.e. redundantly) enabled in setup.py and in the Github CI rules. This had the effect of LTC being left enabled unless the build is triggered by setup.py or Github CI. It also had the effect of forcing us to update the option in multiple places, whenever it needed to be changed. This patch sets the options' default value at the option definintion, and it explicitly sets the value only when the default is overriden, like for disabling MHLO in in-tree builds on macOS.
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, LTC was enabled by default, but it was disabled in
setup.py and in the Github CI rules. MHLO, on the other hand, was
enabled by default, but also (i.e. redundantly) enabled in setup.py and
in the Github CI rules.
This had the effect of LTC being left enabled unless the build is
triggered by setup.py or Github CI. It also had the effect of forcing
us to update the option in multiple places, whenever it needed to be
changed.
This patch sets the options' default value at the option definintion,
and it explicitly sets the value only when the default is overriden,
like for disabling MHLO in in-tree builds on macOS.