Slightly tweak generated file checks #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powderluv
requested changes
Sep 1, 2022
The new logic has the following benefits: 1. It does not clobber the working tree state. We expect testing to not change the work tree. 2. It correctly handles the case where a user has changes to the generated files, but hasn't checked them in yet (this happens frequently when adding new ops).
silvasean
force-pushed
the
generated-ci-2
branch
from
9f08e6b
to
aa6547d
Compare
powderluv
approved these changes
Sep 1, 2022
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* Call MLIR CSE pass to remove common sub-expression Signed-off-by: Tung D. Le <tung@jp.ibm.com> * Add a lit test of CSE for onnx ops Signed-off-by: Tung D. Le <tung@jp.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic has the following benefits:
change the work tree.
generated files, but hasn't checked them in yet (this happens
frequently when adding new ops).