Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle weird xrefs during loading #327

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

njbooher
Copy link
Contributor

The importer initially ran into an issue trying to import xrefs on some features

https://db.scnbase.org/feature/?feature_id=215199

specifically these: GENE3D:G3DSA:1.10.287.770

This resolved it.

I hereby agree to licence this and any previous contributions under
the terms of the GNU General Public License version 3 as published by
the Free Software Foundation

I have read the CONTRIBUTING.rst file and understand that
TravisCI will be used to confirm the tests and flake8 style
checks pass with these changes.

I am happy be thanked by name in the CONTRIB.rst files,
and have added myself to the file as part of this pull request.
(This acknowledgement is optional. Note we list the names sorted alphabetically.)

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2021

Codecov Report

Merging #327 (97ad5a1) into master (72ba56c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   68.71%   68.71%           
=======================================
  Files          30       30           
  Lines        4060     4060           
  Branches      235      235           
=======================================
  Hits         2790     2790           
  Misses       1211     1211           
  Partials       59       59           
Impacted Files Coverage Δ
machado/loaders/feature.py 66.26% <100.00%> (ø)
machado/loaders/featureattributes.py 77.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ba56c...97ad5a1. Read the comment docs.

@azneto azneto merged commit 25618aa into lmb-embrapa:master Jul 29, 2021
@njbooher njbooher deleted the loading-fixes branch July 29, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants