Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: inheritance #15

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix: inheritance #15

merged 1 commit into from
Oct 3, 2023

Conversation

lmignon
Copy link
Owner

@lmignon lmignon commented Oct 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bff82c8) 88.31% compared to head (4d02139) 89.11%.

❗ Current head 4d02139 differs from pull request most recent head 75c0988. Consider uploading reports for the commit 75c0988 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   88.31%   89.11%   +0.79%     
==========================================
  Files           7        7              
  Lines         291      294       +3     
  Branches       67       68       +1     
==========================================
+ Hits          257      262       +5     
+ Misses         21       20       -1     
+ Partials       13       12       -1     
Flag Coverage Δ
unittests 89.11% <100.00%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/extendable/main.py 91.24% <100.00%> (+0.12%) ⬆️
src/extendable/registry.py 86.40% <100.00%> (+1.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix error when a class is extended to add others aggregated classes as parent
classes. Before this fix, the builder used the list of all base classes of
the final class as base classes for every class into the hierarchy.
@lmignon lmignon force-pushed the master-fix-mixin-inheritance branch from 4d02139 to 75c0988 Compare October 3, 2023 16:59
@lmignon lmignon changed the title wip Fix: inheritance Oct 3, 2023
@lmignon lmignon marked this pull request as ready for review October 3, 2023 17:00
@lmignon lmignon merged commit eb4d3ca into master Oct 3, 2023
8 checks passed
@lmignon lmignon deleted the master-fix-mixin-inheritance branch October 3, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant