Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for LUD-19 for boltcards extension #19

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Conversation

gorrdy
Copy link
Contributor

@gorrdy gorrdy commented Sep 13, 2023

LNURLw (withdrawRequest) that is returned by calling the link from bolt card now returns another field "payLink" as defined in LUD-19.

This allows compatible wallet to create e.g. refund or cashback to the card itself without need to create a separate invoice or managing another separate LNURLp or LN address.

Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small style nits

lnurl.py Outdated Show resolved Hide resolved
lnurl.py Outdated Show resolved Hide resolved
lnurl.py Outdated Show resolved Hide resolved
lnurl.py Outdated Show resolved Hide resolved
lnurl.py Outdated Show resolved Hide resolved
gorrdy and others added 2 commits September 14, 2023 05:12
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Copy link
Contributor Author

@gorrdy gorrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied some suggestion on code formatting. thanks @prusnak

@gorrdy gorrdy requested a review from prusnak September 14, 2023 03:29
lnurl.py Show resolved Hide resolved
@dni dni merged commit 76fcd30 into lnbits:main Sep 21, 2023
@arbadacarbaYK
Copy link
Contributor

LUD19 was about tap and top up. How is topping up handled now ? This needs a wiki entry.

@gorrdy
Copy link
Contributor Author

gorrdy commented Sep 25, 2023

LUD19 was about tap and top up. How is topping up handled now ? This needs a wiki entry.

I don't think the topping up is handled in LNbits anyhow. This PR just serves the payLink when tapping the bolt card. It depends on the wallet on the other side how it handles it.

In LNbits I would like a implementation in e.g. TPoS extension in LNbits. Also this extension (boltcards) could have some page that reads the NFC card withDraw link and if there is a payLink field, then show some dialog how many sats to top up. Not sure where this should be in UI.

@arbadacarbaYK
Copy link
Contributor

arbadacarbaYK commented Sep 25, 2023

LUD19 was about tap and top up. How is topping up handled now ? This needs a wiki entry.

I don't think the topping up is handled in LNbits anyhow. This PR just serves the payLink when tapping the bolt card. It depends on the wallet on the other side how it handles it.

In LNbits I would like a implementation in e.g. TPoS extension in LNbits. Also this extension (boltcards) could have some page that reads the NFC card withDraw link and if there is a payLink field, then show some dialog how many sats to top up. Not sure where this should be in UI.

yes because we are waiting on the end of the discussion in the nfc mafia group how we want it. In the desc is not the way, cause it cannot be interpreted by the devices.
Wouldve like to see the end of that first. So far only LUD21 changes for boltcard on tpos are near to ready.
Apart from that LUD17 predescribes lnurlp:// not lnurl as a pay-link.

There also is a status page for boltcards that tal just made that should show this paylink.

This is just half of the story and the documentation is not handled also. LUDs have to be brought in LNbits wide not only for one extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants