-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for LUD-19 for boltcards extension #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small style nits
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
Co-authored-by: Pavol Rusnak <pavol@rusnak.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied some suggestion on code formatting. thanks @prusnak
LUD19 was about tap and top up. How is topping up handled now ? This needs a wiki entry. |
I don't think the topping up is handled in LNbits anyhow. This PR just serves the payLink when tapping the bolt card. It depends on the wallet on the other side how it handles it. In LNbits I would like a implementation in e.g. TPoS extension in LNbits. Also this extension (boltcards) could have some page that reads the NFC card withDraw link and if there is a payLink field, then show some dialog how many sats to top up. Not sure where this should be in UI. |
yes because we are waiting on the end of the discussion in the nfc mafia group how we want it. In the desc is not the way, cause it cannot be interpreted by the devices. There also is a status page for boltcards that tal just made that should show this paylink. This is just half of the story and the documentation is not handled also. LUDs have to be brought in LNbits wide not only for one extension. |
LNURLw (withdrawRequest) that is returned by calling the link from bolt card now returns another field "payLink" as defined in LUD-19.
This allows compatible wallet to create e.g. refund or cashback to the card itself without need to create a separate invoice or managing another separate LNURLp or LN address.