Fixed Description Hash Issue on Opennode #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
requested changes
Jul 1, 2024
| @@ -92,7 +92,7 @@ async def api_lnurl_callback( | |||
| wallet_id=link.wallet, | |||
| amount=int(amount / 1000), | |||
| memo=link.description, | |||
| unhashed_description=unhashed_description, | |||
| unhashed_description=None if get_funding_source().__class__.__name__ == "OpenNodeWallet" else unhashed_description, | |||
There was a problem hiding this comment.
this is an ugly hack and a layering violation - maybe there is a better way how to fix the issue?
There was a problem hiding this comment.
what about adding a member for each wallet class like is_deschash_required and checking it here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LNURLP transactions currently do not work with opennode due to description hash error. I added a conditional check to pass description hash only if the funding source is not OpenNode