WIP Adds withdraw to tpos #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnurl.py
Outdated
| } | ||
| return { | ||
| "tag": "withdrawRequest", | ||
| "callback": request.url_for( |
There was a problem hiding this comment.
I think this now is str(request.url_for(...))
tasks.py
Outdated
| @@ -20,7 +20,7 @@ async def wait_for_paid_invoices(): | |||
|
|
|||
|
|
|||
| async def on_invoice_paid(payment: Payment) -> None: | |||
| if payment.extra.get("tag") != "tpos" or payment.extra.get("tipSplitted"): | |||
| if payment.extra.get("tag") != "tpos": | |||
There was a problem hiding this comment.
keep the tipSplitted or tpos will make double tips on payment
| @@ -52,7 +52,7 @@ async def on_invoice_paid(payment: Payment) -> None: | |||
| wallet_id=wallet_id, | |||
| amount=int(tipAmount), | |||
| internal=True, | |||
| memo="tpos tip", | |||
| memo=f"tpos tip", | |||
templates/tpos/index.html
Outdated
| this.updateTPos(wallet, data) | ||
| } else { | ||
| this.createTPoS(wallet, data) | ||
| if(self.formDialog.data.id != undefined){ |
manifest.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "repos": [ | |||
| { | |||
| "id": "tpos", | |||
| "organisation": "lnbits", | |||
| "organisation": "arcbtc", | |||
There was a problem hiding this comment.
Are this changes ok? your this started in an old tpos repo, and got smuggled here?
README.md
Outdated
| @@ -1,5 +1,4 @@ | |||
| # TPoS - <small>[LNbits](https://github.com/lnbits/lnbits) extension</small> | |||
| <small>For more about LNBits extension check [this tutorial](https://github.com/lnbits/lnbits/wiki/LNbits-Extensions)</small> | |||
| # TPoS | |||
There was a problem hiding this comment.
Are this changes ok? your this started in an old tpos repo, and got smuggled here?
|
Steps to test:
|
dni
reviewed
Oct 12, 2023
|
|
||
| db = Database("ext_tpos") | ||
|
|
||
|
|
||
| class LNURLErrorResponseHandler(APIRoute): |
There was a problem hiding this comment.
this would handle all the /tpos API calls like LNURLErrorResponses right?
btw. i saw that handleer already multiple times in extensions, would it make sense to offer it from core in helpers.py or lnurl.py?
dni
reviewed
Oct 12, 2023
dni
reviewed
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.