Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix atm premium #88

Merged
merged 1 commit into from
May 24, 2024
Merged

hotfix atm premium #88

merged 1 commit into from
May 24, 2024

Conversation

talvasconcelos
Copy link
Collaborator

@talvasconcelos talvasconcelos commented May 24, 2024

  • ATM premium wasn't stored in the DB
  • Value asked in the input is now in percentage (ex: 1, 3.5, etc...)

Test Steps:

  • create or edit a tpos that allows ATM withdraw and set a premium percentage, for testing purposes make that a high value like 20%
  • make the withdraw, check the exchange rate, it should be ~20% less than actual exchange rate (you should get less sats than doing it with the actual rate)

Actual Result:

  • atm premium setting wasn't added to DB
  • atm premium was always 0%, so the real exchange rate was used

Expected Result:

  • the premium value should show on the tpos table
  • the withdraw should account the premium and adjust the amount of sats to withdraw

@talvasconcelos talvasconcelos added bug Something isn't working enhancement New feature or request labels May 24, 2024
@motorina0
Copy link
Collaborator

Please add Test Steps, Actual Result and Expected Result it makes it easier to understand and test the PR.

@arcbtc
Copy link
Member

arcbtc commented May 24, 2024

Doe this calculate the premium correctly in frontend?

@talvasconcelos
Copy link
Collaborator Author

talvasconcelos commented May 24, 2024

Doe this calculate the premium correctly in frontend?

atm with premium has a 25% premium, normal has none, or 0%

simplescreenrecorder-2024-05-24_11.25.27.mp4

@arcbtc arcbtc merged commit bfae062 into main May 24, 2024
@arcbtc arcbtc deleted the mak_atm_premium_pct branch May 24, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants