Skip to content

Move rkyv RPC support to use CRC32 checksums rather than checkbytes and use stack allocated scratch. #186

Move rkyv RPC support to use CRC32 checksums rather than checkbytes and use stack allocated scratch.

Move rkyv RPC support to use CRC32 checksums rather than checkbytes and use stack allocated scratch. #186

Triggered via pull request September 3, 2023 14:35
Status Success
Total duration 9m 37s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

rust.yml

on: pull_request
Matrix: build
Matrix: check
Fit to window
Zoom out
Zoom in

Annotations

55 warnings
check (ubuntu-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check (ubuntu-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (ubuntu-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (ubuntu-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (ubuntu-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (macOS-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check (macOS-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (macOS-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (macOS-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (macOS-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (windows-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
check (windows-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (windows-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (windows-latest, stable)
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
check (windows-latest, stable)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build (ubuntu-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L586
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:586:38 | 586 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L529
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:529:38 | 529 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L469
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:469:38 | 469 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L404
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:404:38 | 404 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/replication_impl.rs#L274
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/replication_impl.rs:274:49 | 274 | _marker: PhantomData::<MemStore>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/replication_impl.rs#L228
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/replication_impl.rs:228:49 | 228 | _marker: PhantomData::<MemStore>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L218
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:218:42 | 218 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L204
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:204:42 | 204 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L176
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:176:38 | 176 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L149
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:149:38 | 149 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L122
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:122:38 | 122 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L93
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:93:38 | 93 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/replication/poller.rs#L513
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/replication/poller.rs:513:34 | 513 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/replication/poller.rs#L504
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/replication/poller.rs:504:38 | 504 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/replication/poller.rs#L471
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/replication/poller.rs:471:38 | 471 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/keyspace/group.rs#L254
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/keyspace/group.rs:254:69 | 254 | if let Err(e) = state.send(PurgeDeletes(PhantomData::<S>::default())).await { | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
use of `default` to create a unit struct: datacake-node/src/lib.rs#L151
warning: use of `default` to create a unit struct --> datacake-node/src/lib.rs:151:43 | 151 | node_selector: DCAwareSelector::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-node/src/nodes_selector.rs#L544
warning: use of `default` to create a unit struct --> datacake-node/src/nodes_selector.rs:544:43 | 544 | let mut selector = DCAwareSelector::default(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
this `impl` can be derived: datacake-rpc/src/rkyv_tooling/scratch.rs#L21
warning: this `impl` can be derived --> datacake-rpc/src/rkyv_tooling/scratch.rs:21:1 | 21 | / impl Default for LazyScratch { 22 | | fn default() -> Self { 23 | | Self { 24 | | stack_scratch: StackScratch::default(), ... | 28 | | } 29 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 15 + #[derive(Default)] 16 | pub struct LazyScratch { |
use of `default` to create a unit struct: datacake-rpc/src/handler.rs#L119
warning: use of `default` to create a unit struct --> datacake-rpc/src/handler.rs:119:37 | 119 | _msg: PhantomData::<Msg>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L586
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:586:38 | 586 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L529
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:529:38 | 529 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L469
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:469:38 | 469 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/lib.rs#L404
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/lib.rs:404:38 | 404 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L218
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:218:42 | 218 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L204
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:204:42 | 204 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L176
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:176:38 | 176 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L149
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:149:38 | 149 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L122
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:122:38 | 122 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/rpc/services/consistency_impl.rs#L93
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/rpc/services/consistency_impl.rs:93:38 | 93 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/replication/poller.rs#L513
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/replication/poller.rs:513:34 | 513 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/replication/poller.rs#L504
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/replication/poller.rs:504:38 | 504 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/replication/poller.rs#L471
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/replication/poller.rs:471:38 | 471 | _marker: PhantomData::<S>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
use of `default` to create a unit struct: datacake-eventual-consistency/src/keyspace/group.rs#L254
warning: use of `default` to create a unit struct --> datacake-eventual-consistency/src/keyspace/group.rs:254:69 | 254 | if let Err(e) = state.send(PurgeDeletes(PhantomData::<S>::default())).await { | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
use of `default` to create a unit struct: datacake-node/src/lib.rs#L151
warning: use of `default` to create a unit struct --> datacake-node/src/lib.rs:151:43 | 151 | node_selector: DCAwareSelector::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
this `impl` can be derived: datacake-rpc/src/rkyv_tooling/scratch.rs#L21
warning: this `impl` can be derived --> datacake-rpc/src/rkyv_tooling/scratch.rs:21:1 | 21 | / impl Default for LazyScratch { 22 | | fn default() -> Self { 23 | | Self { 24 | | stack_scratch: StackScratch::default(), ... | 28 | | } 29 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 15 + #[derive(Default)] 16 | pub struct LazyScratch { |
use of `default` to create a unit struct: datacake-rpc/src/handler.rs#L119
warning: use of `default` to create a unit struct --> datacake-rpc/src/handler.rs:119:37 | 119 | _msg: PhantomData::<Msg>::default(), | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
build (macOS-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (windows-latest, stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/