Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-empty-description rule. closes #302 #304

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Add no-empty-description rule. closes #302 #304

merged 2 commits into from
Dec 1, 2021

Conversation

pustovitDmytro
Copy link
Contributor

This rule enforces specifying the suite/test descriptions for each test.

The following patterns are considered problems:

it();
suite("");
test(function() { })
test.only(" ", function() { })

also, I added this rule to the recommendations list.

lo1tuma
lo1tuma approved these changes Nov 30, 2021
View reviewed changes
Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

lo1tuma
lo1tuma approved these changes Dec 1, 2021
View reviewed changes
Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo1tuma lo1tuma merged commit 9c414a5 into lo1tuma:master Dec 1, 2021
@lo1tuma lo1tuma added the feature label Dec 1, 2021
@neverendingqs neverendingqs mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo1tuma lo1tuma lo1tuma approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pustovitDmytro @lo1tuma