Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use npm-run-all to run lint/test scripts #308

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Dec 8, 2021

Adds popular tool npm-run-all for running scripts.

Benefits:

  • Single script to run all types of linting in parallel (run-p is alias for npm-run-all --parallel)
  • Uses double quotes instead of single quotes for better cross-platform support
  • Uses npm-run-all instead of && for better cross-platform support

    Cross platform. We sometimes use & to run multiple command in parallel, but cmd.exe (npm run-script uses it by default) does not support the &. Half of Node.js users are using it on Windows, so the use of & might block contributions. npm-run-all --parallel works well on Windows as well.

package.json Show resolved Hide resolved
@lo1tuma lo1tuma merged commit 60120a9 into lo1tuma:master Dec 8, 2021
@lo1tuma lo1tuma added the build label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants