Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON output logging is too noisy #1469

Closed
na-- opened this issue May 28, 2020 · 1 comment
Closed

JSON output logging is too noisy #1469

na-- opened this issue May 28, 2020 · 1 comment
Labels
good first issue lower prio performance ux
Milestone
v0.27.0

Comments

@na--
Copy link
Member

na-- commented May 28, 2020

When k6 is ran in verbose mode and outputting metrics to a JSON file, the log is full of useless debug messages:

time="2020-05-28T13:35:10+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:10+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="2.379µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="2.391µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="3.86µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="4.195µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="7.062µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="32.689µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="6.224µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=2 filename=output.json t="103.97µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="6.374µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="3.807µs"
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:11+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="4.033µs"
time="2020-05-28T13:35:12+03:00" level=debug msg="JSON: Writing JSON metrics" filename=output.json
time="2020-05-28T13:35:12+03:00" level=debug msg="JSON: Wrote JSON metrics" count=0 filename=output.json t="3.672µs"

The Writing JSON metrics message seems completely superfluous, and the Wrote JSON metrics should probably only be shown when we actually wrote something - most of these have count=0... Also, 100ms seems way to small of an interval to write metrics in a file, so investigating if bigger batches aren't better is probably worthwhile.
@michiboo michiboo mentioned this issue May 28, 2020
Merged
@imiric
Copy link
Contributor

imiric commented Jun 12, 2020

Closed by #1470.

@imiric imiric closed this as completed Jun 12, 2020
@imiric imiric added this to the v0.27.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue lower prio performance ux
Projects
None yet
Milestone
v0.27.0
Development

No branches or pull requests
2 participants
@imiric @na--