Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preload grafana dashboard with docker-compose setup #1610

Merged
merged 4 commits into from
Sep 2, 2020

Conversation

jeevananthank
Copy link
Contributor

@jeevananthank jeevananthank commented Aug 27, 2020

Today's setup of docker-compose does not preload the dashboard when running the tests locally. This PR solves the issues and detailed description is in the link below.

The grafana dashboard used here is more generic and simple and one can update as per their needs.

https://community.k6.io/t/preload-grafana-dashbaord-with-docker-compose-setup/874

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2020

Codecov Report

Merging #1610 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1610   +/-   ##
=======================================
  Coverage   74.82%   74.82%           
=======================================
  Files         164      164           
  Lines       14035    14035           
=======================================
  Hits        10501    10501           
  Misses       3002     3002           
  Partials      532      532           
Impacted Files Coverage Δ
lib/testutils/minirunner/minirunner.go 78.57% <0.00%> (-3.58%) ⬇️
lib/executors.go 94.11% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68a4eb...9bd3569. Read the comment docs.

mstoykov
mstoykov previously approved these changes Aug 28, 2020
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have some reservations about us putting, even more, grafana specific things in the k6 repo ... because even now people ask us questions that are grafana/influxdb related. And to be perfectly honest I don't think we should be the one trying to answer them, and usually, it requires that we go read the grafana/influxdb documentation to figure it out, which arguably should be what, the person who asked the question, have done in the first place.

Copy link
Contributor

@simskij simskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I share your concern @mstoykov, but suggest we merge this for now and continue the discussions about whether to split this out to another repo in a separate forum.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually tried the new default dashboard, but considering we're soon going to move the docker-compose files to a separate example repo (#1614), LGTM 😅

@na-- na-- merged commit 5703bfa into grafana:master Sep 2, 2020
@na-- na-- added this to the v0.28.0 milestone Sep 2, 2020
@simskij
Copy link
Contributor

simskij commented Sep 2, 2020

Thank you so much for your contribution, @jeevananthank! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants