Skip to content

Commit

Permalink
OpenTelemetry Environment Variable from ConfigMap variable (#23)
Browse files Browse the repository at this point in the history
* add conditional otel env variables in deployment.yaml

* add changelog and v0.7.2 bump

* remove conditional otel hostname env var

* change changelog entry
  • Loading branch information
alehechka authored Aug 17, 2023
1 parent a0c4136 commit b7e4601
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
6 changes: 6 additions & 0 deletions charts/microservice/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Security

## [v0.7.2] - 2023-08-16

### Fixed

- OpenTelemetry environment variables to reference ConfigMap variable (https://github.com/lockerstock/helm-charts/pull/23).

## [v0.7.1] - 2023-07-28

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion charts/microservice/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 'v0.7.1'
version: 'v0.7.2'

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
5 changes: 4 additions & 1 deletion charts/microservice/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ spec:

{{- if .Values.deployment.opentelemetry.enabled }}
- name: OTEL_EXPORTER_OTLP_ENDPOINT
value: k8s-app-opentelemetry:4317
valueFrom:
configMapKeyRef:
name: otel-collector-routing
key: grpcAddress
{{- end }}

{{- if .Values.deployment.cache.enabled }}
Expand Down

0 comments on commit b7e4601

Please sign in to comment.