-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend, ingest): Only return get-original-data when the aux-table is empty #2846
Conversation
I tried to add a test, e.g. but this fails as the auxtable is empty:
|
CCHF ingest was stopped by this new 503 response:
But sadly it doesn't seem like the ingest deployment is restarting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(I can't see an easy way to add a test - if anyone does know how we can aim to do that)
backend/src/main/kotlin/org/loculus/backend/controller/SubmissionController.kt
Outdated
Show resolved
Hide resolved
Testing it would have probably been possible by "manually" adding something to the aux tables. I.e. calling a function from the test that inserts a row to simulate being in the middle of an upload. |
@fengelniederhammer makes sense. I'm just not familiar with the framework we're using here. Would be great if you could add such a test in a PR! |
…sions This is a follow-up to #2846
…sions This is a follow-up to #2846
resolves #
preview URL: https://check-aux-table.loculus.org/
Summary
As discussed in slack there is a period between when sequences are submitted and will be seen in
get-original-data
, in this period sequences are added to the aux tables. To prevent ingest errors we should not return original data while the backend is still processing sequences, e.g. there is data in the aux tables. When there is data in the aux tables get-original-data will respond with 423 LOCKED.Also update ingest to wait 30seconds after a LOCKED response and then retry.
Also update ingest get-submitted to not add "" to dictionary when segment is missing and thus insdc_accession_segment does not exist.
Screenshot
Update I added a sequence to cchf that is why there is one sequence!
PR Checklist