-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting run time from the web UI / http api #2202
Conversation
All in one PR is best! |
self.environment.user_classes = [MyUser] | ||
self.environment.web_ui.parsed_options = parse_options() | ||
response = requests.post( | ||
"http://127.0.0.1:%i/swarm" % self.web_port, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test!!
Can I bother you to make some kind of "Advanced" button that hides/exposes this field? There are several other options that the user might want to set, but we dont want to show it all the time. |
* Use Python 3.10 type hint syntax for Union types * Use Python 3.10 type hint syntax for Union types (in more places) * Use Python 3.10 type hint syntax for Union types (fix) * Use Python 3.10 type hint syntax for Union types (fix) * Use Python 3.10 type hint syntax for Union types (fix) * one more try on web.py * clients.py maybe maybe maybe * fix users.py * more types * Remove unnecessary type hint
Added a flag (similar to class-picker) to pass to the master. |
…count-reset-when-using-class-picker Bug Fix for User Class Count reset when editing a running test and using --class-picker
Maybe you could have a look at the "advanced" button I suggested? We already have too many command line options for enabling stuff in the UI :) (e.g. |
Very nice, thanks! Something broke with the tests though... |
Looking into it, for some reason the tests pass on my local. I do see there was a recent merge to master. Should I try a rebase? |
Looks like the rebase fixed the tests |
The diff looks really bad, but I think it is just git messing with us :) LGTM! |
#2198
Implemented only the rest portion of the above issue. Should I have a separate PR for the ui component or make another commit to this PR?