Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charset_normalizer dependency #2506

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add charset_normalizer dependency #2506

merged 1 commit into from
Dec 18, 2023

Conversation

KellyP5
Copy link
Contributor

@KellyP5 KellyP5 commented Dec 6, 2023

A previous PR introduced charset_normalizer as a dep, but did not explicitly add it to the pyproject.toml file.

This causes a breaking change on import.

So this PR explicitly includes it.

Resolves #2505

@cyberw
Copy link
Collaborator

cyberw commented Dec 6, 2023 •
edited
Loading

charset-normalizer is a dependency of requests, so this shouldnt be necessary. Are you sure you didnt just have a broken install somehow?

@cyberw cyberw added the stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it label Dec 8, 2023
@cyberw cyberw closed this Dec 12, 2023
@cyberw cyberw reopened this Dec 18, 2023
@cyberw cyberw merged commit 0f68228 into locustio:master Dec 18, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale Issue had no activity. Might still be worth fixing, but dont expect someone else to fix it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing charset_normalizer dependency
2 participants
@KellyP5 @cyberw