Chart Average Response Time in Modern UI #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbaldwin44
force-pushed
the
feature/swarm-chart-percentiles
branch
2 times, most recently
from
3e89904 to
5062e7c
Compare
|
nice! is it possible to change PERCENTILES_TO_CHART default to only 0.95, by checking if modern ui is set? (because we dont need avg AND 50th percentile) |
andrewbaldwin44
force-pushed
the
feature/swarm-chart-percentiles
branch
from
5062e7c to
c9a4b85
Compare
|
Nice! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
PERCENTILES_TO_CHARTis being passed to the modern UI. We will now pass an array of all the percentiles we wish to chart. This will allow users to continue extending this variable as they wish, and it will additionally allow for users to see as many different percentiles in the chart as they would liketotalAvgResponseTimeto response from/stats/requestsand add it to the chart in the modern UIMODERN_UI_PERCENTILES_TO_CHARTto the stats module. This variable can still optionally be overriden from a locust fileScreenshots