Support IPv6 for zmq connection between master and worker #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to have the same issue as the previous PR. I’m all for supporting ipv6, but someone needs to figure out the GH/build issue. |
Do you mean the |
|
test fixed. |
cyberw
changed the title
cyberw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for PR #2290.
The solution is based on http://api.zeromq.org/4-2:zmq-setsockopt.
The test is done with kind for 3 env, ipv4 only, ipv6 only and dual stack. With help of https://abdelrhmanhamouda.github.io/locust-k8s-operator/
Test result:
ipv4-only before-patch(success) after-patch(success)
ipv6-only before-patch(fail, the worker can't connect with master) after-patch(success)
dualstack before-patch(success) after-patch(success)