Use Modern UI by default #2569
Use Modern UI by default #2569
Conversation
|
Nice! Why are some of the tests run with legacy UI though? Ideally they should work in both, of course, but it is most important that they work in modern-ui :) |
|
Yeah it's because they are testing things using the legacy UI templates or the legacy UI HTML template. Even though we are not developing the legacy UI anymore, I figured we should keep them to ensure new developments to the modern UI don't cause regressions |
|
Yea, testing some things with the old UI totally makes sense. But why wouldnt we want to test |
|
Oh the |
|
But |
|
Yeah you're right, but I believe it's because of this line: |
|
Hows about you update the test so that it works with modern UI but add a ”legacy” test (based this one or one of the more basic ones) that run with legacy ui? |
andrewbaldwin44
force-pushed
the
feature/modern-ui-default
branch
from
31aebde to
641ed7d
Compare
|
Ok I updated the autorun tests. They don't run against the legacy UI anymore, but I think these should be sufficient since we're not really testing the UI, but rather the output of the template arguments to ensure the state is set as "running" |
Changes implemented
--modern-uiflag to be--legacy-uiand updated the relevant tests to use this flag