fix(dispatch): UserClasses weight distribution with gcd #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Can I ask that you add a unit test that would fail with the old implementation? |
|
Tests seem to hang on python 3.8. That’s really weird.. |
|
I fixed the hanging tests in python 3.8. The reason turned out to be that the prototype of the function "math.gcd" was changed in version 3.9. As a result, support is now provided starting from version 3.5. Why exactly "actions" hang and not throw an exception is a good question. |
|
Nice. Support for python 3.8 is deprecated anyway (and it python 3.8 is eol in october, after which we’ll probably stop supporting it), but it is nice that we dont have to kill it right away :) |
|
Added unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2662