Add glob support to ignores #76
Conversation
I was confused when first reading through the test output as to what is framework output and what is test output. I think more verbose test names helps allow newcomers scan the list and make more sense out of it.
In contrast to a method, because, apparently go generics doesn't allow generic methods.
Meaning I hopefully can de-duplicate the two implementations
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 66.89% 67.94% +1.05%
==========================================
Files 13 13
Lines 441 443 +2
==========================================
+ Hits 295 301 +6
+ Misses 129 127 -2
+ Partials 17 15 -2
Continue to review full report at Codecov.
|
|
Great! Thanks for the PR! I am currently on vacation and get back to you asap |
|
Gentle ping @loeffel-io, just wanted to make sure that you didn't forget about this PR 😅 |
|
What's the status on this? Feels very high priority. |
|
@loeffel-io friendly ping :) Anything I can do to move this along? Thanks! |
|
Would be great to get this merged and published. There doesn't seem to be a good way to ignore certain folder names in arbitrary locations in a repo. I have a monorepo with multiple tests folders that I would like to ignore. |
|
Hey folks, sorry that this takes so long - the support will come! This will come together with https://github.com/github/super-linter/issues/2505#issuecomment-1263886322 as soon i have enough mind capacity |
|
@loeffel-io Is there anything we can do to help get this merged? Seems like it has been stale for a bit. |
There was a problem hiding this comment.
thank you @hanneskaeufler!
The tests are not meaningful enough imo - we should add ignore mid path tests and some more ignore variations.
is there a reason for removing the globIndex func from the config struct?
thanks!
|
ping from here as well; I need glob support in the |
|
no support for ignore globs is a show-stopper for me. |
|
Very happy to announce that This feature (add glob support to ignores) is planned for |
|
This is now supported with |
As is on the v2 wishlist and was mentioned in #35 and #56 (comment), globbing is currently not allowed for the
ignorekey.This is a first try at implementing this.
Performance
All measurements done on an 2020 M1 MacBook Air with 8GB of ram.
Using hyperfine, I ran
hyperfine './ls-lint'with the current local build of ls-lint as well as with master. I did a couple variations, based on the example config:node_modulesin ignoreTime (mean ± σ): 16.0 ms ± 0.8 ms [User: 7.4 ms, System: 8.7 ms]'**/node_modules'in ignoreTime (mean ± σ): 282.4 ms ± 21.8 ms [User: 71.7 ms, System: 210.1 ms]node_modulein ignoreTime (mean ± σ): 15.9 ms ± 0.7 ms [User: 7.3 ms, System: 8.7 ms]This kind of confirms what makes some sense: If you use a glob in ignores, depending on the size of your project, you pay a significant penalty in performance. If you don't use any globs, you don't pay measurably.