Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Validating Webhook accounts.config.kiosk.sh #2

Closed
FabianKramm opened this issue Feb 4, 2020 · 4 comments
Closed

Validating Webhook accounts.config.kiosk.sh #2

FabianKramm opened this issue Feb 4, 2020 · 4 comments
Labels
area/manager kind/enhancement

Comments

@FabianKramm
Copy link
Member

FabianKramm commented Feb 4, 2020 •
edited
Loading

We need a validating webhook for accounts.config.kiosk.sh, that checks for the following things:

  • Create / Update:
    • Space Template spec.account has to be unfilled
@FabianKramm FabianKramm changed the title Add validating webhook for accounts.config.kiosk.sh Add missing validating webhooks Feb 14, 2020
@FabianKramm FabianKramm changed the title Add missing validating webhooks Validating Webhook accounts.config.kiosk.sh Feb 14, 2020
@rahulchheda
Copy link
Contributor

Is this issue still available? @FabianKramm ?

@rahulchheda
Copy link
Contributor

Would like to start working on this.

@FabianKramm
Copy link
Member Author

@rahulchheda yes there is still a check missing if the account field in the space template is unfilled currently, would be great if you would open a pr for this!

@rahulchheda rahulchheda mentioned this issue Jun 2, 2020
Merged
@FabianKramm
Copy link
Member Author

implemented by #64

@FabianKramm FabianKramm mentioned this issue Jun 4, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/manager kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FabianKramm @rahulchheda