You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
@rahulchheda yes this is still available, currently the check if the specified resources are valid is still missing, would be great if you would open a pr for this!
@rahulchheda sure, in essence this issue is similar to #2, however this time we want to validate the AccountQuota field spec.quota. We want to do the exact same checks as kubernetes does for ResourceQuota spec, hence I think the best way is to reuse most of the validation kubernetes does for this type (corev1.ResourceQuotaSpec) if possible, you can take a look how kubernetes does it here: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L5339 .
I think the best idea would be to copy over the relevant code from them (because we do not want github.com/kubernetes/kubernetes as a dependency, see kubernetes/kubernetes#80339 (comment) for more details) and change their internal *core.ResourceQuotaSpec type to the one we use *corev1.ResourceQuotaSpec.
AccountQuota needs a validating webhook to check for the following things:
The text was updated successfully, but these errors were encountered: