fix: IPFamilyPolicy not synced for default vcluster service

Signed-off-by: Rohan CJ <rohantmp@gmail.com>
loft-sh · Mar 14, 2024 · 774abc9 · 774abc9
1 parent 416b991
commit 774abc9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pkg/specialservices/proxy_service_syncer.go b/pkg/specialservices/proxy_service_syncer.go
@@ -76,6 +76,7 @@ func SyncVclusterProxyService(ctx *synccontext.SyncContext,
 		newService.Spec.ClusterIP = pObj.Spec.ClusterIP
 		newService.Spec.ClusterIPs = pObj.Spec.ClusterIPs
 		newService.Spec.IPFamilies = pObj.Spec.IPFamilies
+		newService.Spec.IPFamilyPolicy = pObj.Spec.IPFamilyPolicy
 
 		// delete & create with correct ClusterIP
 		err = vClient.Delete(ctx.Context, vObj)

diff --git a/pkg/specialservices/service_syncer.go b/pkg/specialservices/service_syncer.go
@@ -53,14 +53,18 @@ func SyncKubernetesService(
 		return err
 	}
 
+	// detect if cluster ips changed
+	clusterIPsChanged := vObj.Spec.ClusterIP != pObj.Spec.ClusterIP || !equality.Semantic.DeepEqual(vObj.Spec.ClusterIPs, pObj.Spec.ClusterIPs)
+
 	translatedPorts := svcPortTranslator(pObj.Spec.Ports)
-	if vObj.Spec.ClusterIP != pObj.Spec.ClusterIP || !equality.Semantic.DeepEqual(vObj.Spec.Ports, translatedPorts) {
+	if clusterIPsChanged || !equality.Semantic.DeepEqual(vObj.Spec.Ports, translatedPorts) {
 		newService := vObj.DeepCopy()
 		newService.Spec.ClusterIP = pObj.Spec.ClusterIP
 		newService.Spec.ClusterIPs = pObj.Spec.ClusterIPs
 		newService.Spec.IPFamilies = pObj.Spec.IPFamilies
+		newService.Spec.IPFamilyPolicy = pObj.Spec.IPFamilyPolicy
 		newService.Spec.Ports = translatedPorts
-		if vObj.Spec.ClusterIP != pObj.Spec.ClusterIP || !equality.Semantic.DeepEqual(vObj.Spec.ClusterIPs, pObj.Spec.ClusterIPs) {
+		if clusterIPsChanged {
 			// delete & create with correct ClusterIP
 			err = ctx.VirtualClient.Delete(ctx.Context, vObj)
 			if err != nil {