Skip to content

Commit

Permalink
Merge pull request #1696 from loft-sh/thomaskosiewski/fix-semver
Browse files Browse the repository at this point in the history
fix: Semvare compare missing a v character
  • Loading branch information
FabianKramm committed Apr 16, 2024
2 parents b4d3a7e + 2787b9a commit ace2d31
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/vclusterctl/cmd/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ func isVClusterDeployed(release *helm.Release) bool {
// migratelegacyHelmValues migrates the values of the current vCluster to the new config format.
// Only returns a non-empty string if the passed in release is < v0.20.0.
func migrateLegacyHelmValues(release *helm.Release) (string, error) {
if semver.Compare(release.Chart.Metadata.Version, "v0.20.0-alpha.0") != -1 {
if semver.Compare("v"+release.Chart.Metadata.Version, "v0.20.0-alpha.0") != -1 {
// No need to migrate new releases.
return "", nil
}
Expand Down

0 comments on commit ace2d31

Please sign in to comment.