Merge pull request #2117 from facchettos/eso-integration-config

added options to sync the secret stores in eso integration
loft-sh · Sep 5, 2024 · f854283 · f854283
2 parents 39c1444 + 90c40cf
commit f854283
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/chart/templates/role.yaml b/chart/templates/role.yaml
@@ -94,11 +94,18 @@ rules:
     resources: ["virtualmachines", "virtualmachines/status", "virtualmachineinstances", "virtualmachineinstances/status", "virtualmachineinstancemigrations", "virtualmachineinstancemigrations/status"]
     verbs: ["create", "delete", "patch", "update", "get", "list", "watch"]
   {{- end }}
-  {{- if  (and .Values.integrations.externalSecrets.enabled .Values.integrations.externalSecrets.sync.externalSecrets.enabled) }}
+  {{- if  .Values.integrations.externalSecrets.enabled }}
+  {{- if  .Values.integrations.externalSecrets.sync.externalSecrets.enabled }}
   - apiGroups: ["external-secrets.io"]
     resources: ["externalsecrets"]
     verbs: ["create", "delete", "patch", "update", "get", "list", "watch"]
   {{- end }}
+  {{- if   .Values.integrations.externalSecrets.sync.stores.enabled }}
+  - apiGroups: ["external-secrets.io"]
+    resources: ["secretstores"]
+    verbs: ["create", "delete", "patch", "update", "get", "list", "watch"]
+  {{- end }}
+  {{- end }}
   {{- include "vcluster.customResourceDefinitions.roleExtraRules" . | indent 2 }}
   {{- include "vcluster.plugin.roleExtraRules" . | indent 2 }}
   {{- include "vcluster.generic.roleExtraRules" . | indent 2 }}

diff --git a/chart/tests/role_test.yaml b/chart/tests/role_test.yaml
@@ -198,6 +198,31 @@ tests:
             apiGroups: ["external-secrets.io"]
             resources: ["externalsecrets"]
             verbs: ["create", "delete", "patch", "update", "get", "list", "watch"]
+  - it: external secret test store sync
+    set:
+      integrations:
+        externalSecrets:
+          enabled: true
+          sync:
+            externalSecrets:
+              enabled: true
+            stores:
+              enabled: true
+    release:
+      name: my-release
+      namespace: my-namespace
+    asserts:
+      - hasDocuments:
+          count: 1
+      - equal:
+          path: kind
+          value: Role
+      - contains:
+          path: rules
+          content:
+            apiGroups: ["external-secrets.io"]
+            resources: ["secretstores"]
+            verbs: ["create", "delete", "patch", "update", "get", "list", "watch"]
   - it: kubeVirt test
     set:
       integrations: