Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema comments: change vCluster to virtual cluster when not referring to the product itself #1598

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

aimeeu
Copy link
Contributor

@aimeeu aimeeu commented Mar 15, 2024

A few nits:

  • "vCluster" has a copyright, so we need to use virtual cluster when not talking about the product/app.
  • a few changes to standardize terms and products

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

Note: Pascal showed me what to do to generate the partials needed for the docs, so I can do that after this PR merges.

... the product.

Change kubernetes to Kubernetes
@aimeeu aimeeu requested a review from FabianKramm March 15, 2024 18:14
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit d4407cc
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/65f4900f80dda4000803d53d

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimeeu thanks a lot for the PR! LGTM!

@FabianKramm FabianKramm merged commit d182d48 into main Mar 17, 2024
71 checks passed
@ThomasK33 ThomasK33 deleted the comments branch June 3, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants