feat: add migration function #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
FabianKramm
force-pushed
the
main
branch
7 times, most recently
from
ea57a4c
to
a09472b
Compare
FabianKramm
changed the title
|
Thanks @FabianKramm, what about the cases following line vcluster/pkg/config/legacyconfig/migrate.go Line 747 in f783bcd Are these situations where we bail out and the user has to manually remove fields from the previous config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
Resolves ENG-3085
What does it do?
values.yamlinto the newvcluster.yamlformat.fallbackHostDnsback tofalse, which was a mistake introduced when changing thevalues.yamlformat