Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define global in subchart json schema #1652

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Apr 5, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #1651

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster helm chart could not be used as a subchart.

What else do we need to know?

I added the Global interface to config/config.go, regenerated the schema, ran helm lint, and verified helm template on a chart with a vcluster subchart succeeded.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 3ffc859
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/661029abf61118000847d376

@heiko-braun
Copy link
Contributor

Hi @joebowbeer thanks for the contribution. The schema.json is generated from [1] using [2].

Can you adjust the PR to get changes into [1]?

[1] https://github.com/loft-sh/vcluster/blob/main/config/config.go
[2]

generate-config-schema:

@joebowbeer
Copy link
Contributor Author

joebowbeer commented Apr 5, 2024

@heiko-braun instead of adding it to config.go, I wonder if it would be better to emit it in the generator:

https://github.com/loft-sh/vcluster/blob/main/hack/schema/main.go

Thoughts?

@FabianKramm
Copy link
Member

@joebowbeer if global shows up in the values.yaml it needs to be in the config as well, as we pass the whole values.yaml to the syncer and that will strictly parse it. So I guess we need to add the following to the config.go:

Global interface{} `json:"global,omitempty"`

Signed-off-by: Joe Bowbeer <joe.bowbeer@gmail.com>
@joebowbeer
Copy link
Contributor Author

@FabianKramm updated, PTAL

@FabianKramm FabianKramm merged commit 6016bee into loft-sh:main Apr 8, 2024
71 checks passed
@joebowbeer joebowbeer deleted the subchart-fix branch April 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart: Add global property to schema to enable use as subchart
3 participants