chore: perform early exit when no values file is given for vcluster < v0.20 #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
johannesfrey
force-pushed
the
vcluster-early-exist-upgrade
branch
from
399c30b
to
bad5837
Compare
johannesfrey
changed the title
FabianKramm
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Resolves ENG-3303
Please provide a short message that should be published in the vcluster release notes
Really hacky. Interims solution until we have the functionality to check for distro/backingStore switches coming with #1668. This PR only does an early-exist when we try to upgrade a currently running virtual cluster without providing a values file (which might switch distros under the hood). We also print an info message to upgrade values if we connect to a currently running virtual cluster < v0.20.
What else do we need to know?