fix: let pro commands fail instead of succeed

cmd/vcluster/cmd/start.go

@@ -60,7 +60,7 @@ func ExecuteStart(ctx context.Context, options *StartOptions) error {
 		}
 
 		log.Info("In order to use a Pro feature, please contact us at https://www.vcluster.com/pro-demo or downgrade by running `vcluster upgrade --version v0.19.5`")
-		os.Exit(0)
+		os.Exit(1)
 	}
 
 	// get current namespace

cmd/vclusterctl/cmd/create.go

@@ -275,7 +275,7 @@ func (cmd *CreateCmd) Run(ctx context.Context, args []string) error {
 
 		if config.ShouldCheckForProFeatures() && cfg.IsProFeatureEnabled() {
 			cmd.log.Warnf("In order to use a Pro feature, please contact us at https://www.vcluster.com/pro-demo or downgrade by running `vcluster upgrade --version v0.19.5`")
-			os.Exit(0)
+			os.Exit(1)
 		}
 
 		// TODO(johannesfrey): We would also need to validate here if the user is about to perform changes which would lead to distro/store changes

cmd/vclusterctl/cmd/import.go

@@ -60,7 +60,7 @@ vcluster import my-vcluster --cluster connected-cluster \
 		RunE: func(cobraCmd *cobra.Command, args []string) error {
 			if config.ShouldCheckForProFeatures() {
 				cmd.Log.Warnf("In order to use a Pro feature, please contact us at https://www.vcluster.com/pro-demo or downgrade by running `vcluster upgrade --version v0.19.5`")
-				os.Exit(0)
+				os.Exit(1)
 			}
 
 			proClient, err := procli.CreateProClient()

cmd/vclusterctl/cmd/login.go

@@ -43,7 +43,7 @@ vcluster login https://my-vcluster-pro.com --access-key myaccesskey
 		RunE: func(cobraCmd *cobra.Command, args []string) error {
 			if config.ShouldCheckForProFeatures() {
 				cmd.Log.Warnf("In order to use a Pro feature, please contact us at https://www.vcluster.com/pro-demo or downgrade by running `vcluster upgrade --version v0.19.5`")
-				os.Exit(0)
+				os.Exit(1)
 			}
 
 			return cmd.RunLogin(cobraCmd.Context(), args)

cmd/vclusterctl/cmd/logout.go

@@ -41,7 +41,7 @@ vcluster logout
 		RunE: func(cobraCmd *cobra.Command, args []string) error {
 			if config.ShouldCheckForProFeatures() {
 				cmd.Log.Warnf("In order to use a Pro feature, please contact us at https://www.vcluster.com/pro-demo or downgrade by running `vcluster upgrade --version v0.19.5`")
-				os.Exit(0)
+				os.Exit(1)
 			}
 
 			_, err := procli.CreateProClient()

cmd/vclusterctl/cmd/pro/start.go

@@ -79,7 +79,7 @@ before running this command:
 func (cmd *StartCmd) Run(ctx context.Context) error {
 	if config.ShouldCheckForProFeatures() {
 		cmd.Log.Warnf("In order to use a Pro feature, please contact us at https://www.vcluster.com/pro-demo or downgrade by running `vcluster upgrade --version v0.19.5`")
-		os.Exit(0)
+		os.Exit(1)
 	}
 
 	// get version to deploy

cmd/vclusterctl/cmd/ui.go

@@ -42,7 +42,7 @@ vcluster ui
 		RunE: func(cobraCmd *cobra.Command, args []string) error {
 			if config.ShouldCheckForProFeatures() {
 				cmd.Log.Warnf("In order to use a Pro feature, please contact us at https://www.vcluster.com/pro-demo or downgrade by running `vcluster upgrade --version v0.19.5`")
-				os.Exit(0)
+				os.Exit(1)
 			}
 
 			err := cmd.Run(cobraCmd.Context(), args)