Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow specifying resources for init container #1705

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

FabianKramm
Copy link
Member

@FabianKramm FabianKramm commented Apr 18, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #1678
resolves ENG-3389

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for vcluster-docs ready!

Name Link
🔨 Latest commit 1e65a29
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66211d6d2b6c270008233b7d
😎 Deploy Preview https://deploy-preview-1705--vcluster-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@facchettos facchettos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if possible we should also change the config in follow up pr to have map[string]string for resources

@FabianKramm FabianKramm merged commit 2589c2b into loft-sh:main Apr 18, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard-coded request.cpu 30m for statefulset prevents deployment in some cluster
2 participants