feat: multinamespace name config #1786
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
|
Thanks @imkira , would you mind to rebase this one? |
imkira
force-pushed
the
agora-multi-namespace-name-config
branch
from
890d322
to
8d72aa7
Compare
|
@heiko-braun Hey, thanks for reaching out. Yes, I did the rebase. PTAL. |
Support more flexible namespace naming format in the multi name space mode via configuration. Co-authored-by: Ajith Chandran <ajith.chandran@woven.toyota> Co-authored-by: Wojtek Koronski <wojtek.koronski@woven.toyota>
imkira
force-pushed
the
agora-multi-namespace-name-config
branch
from
8d72aa7
to
60d2cc3
Compare
|
@heiko-braun I rebased again (and worked through some conflicts). Could you please take another look and consider the merge? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Support more flexible namespace naming format in the multi name space mode via configuration.
Please provide a short message that should be published in the vcluster release notes
Added more flexible namespace format (prefix, base, suffix) in multi-namespace mode
What else do we need to know?
This is part of a collaborative work at Woven by Toyota with my colleagues @ajithcnambiar and @tauxi