chore(cli/config): unify config and make location configurable #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
johannesfrey
force-pushed
the
vclusterctl-config
branch
from
e527547
to
cd4f887
Compare
johannesfrey
force-pushed
the
vclusterctl-config
branch
3 times, most recently
from
840a3c4
to
8822461
Compare
johannesfrey
commented
May 24, 2024
| ) | ||
|
|
||
| type LoginOptions struct { | ||
| Manager string | ||
| const PlatformURL = "VCLUSTER_PLATFORM_URL" |
There was a problem hiding this comment.
Wasn't sure about this?! Adapted the behaviour from here
johannesfrey
force-pushed
the
vclusterctl-config
branch
7 times, most recently
from
b37be26
to
da57071
Compare
johannesfrey
commented
May 24, 2024
johannesfrey
force-pushed
the
vclusterctl-config
branch
from
da57071
to
79c8dae
Compare
johannesfrey
commented
May 25, 2024
FabianKramm
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Part of ENG-3722
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would create multiple config files in multiple places.
What else do we need to know?
--configflagUpdated the loft deps (not latest, though) to incorporate: https://github.com/loft-sh/loft-enterprise/commit/bd4285e840c1c3d4157265a71e72daaae6f12c51
Therefore, many changed files are actual changes in
vendor, which don't need to be reviewed.Some deps to loftctl have already been removed, but there are many left. Those will be cleaned up in follow-up PRs.