Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credits command not working #1805

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

rohantmp
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
part of ENG-3803

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster credits was not properly populated

What else do we need to know?

Copy link

netlify bot commented May 28, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 0715c5c
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6655b01ea3305a00089aebb3

Copy link
Member

@ThomasK33 ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't part of this PR, but vCluster does not use modernc.org/mathutil or github.com/mattn/go-localereader.

Would you mind removing the license attributions for those libs?

Signed-off-by: Rohan CJ <rohantmp@gmail.com>
@rohantmp
Copy link
Contributor Author

done :)

@ThomasK33 ThomasK33 merged commit 198a505 into loft-sh:main May 28, 2024
5 checks passed
@rohantmp rohantmp deleted the fixCreditsCmd branch May 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants