Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow updating the virtual cluster using the platform driver #1889

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

lizardruss
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
part of ENG-3891

What else do we need to know?
While authoring docs, I found it was not possible to edit a previously created virtual cluster using the CLI command like:

vcluster create my-vcluster --values tests/vcluster.yaml --project default --use

This was due to several issues that are addressed by this PR:

  • the platform driver incorrectly detected that the virtual cluster was deployed by helm
  • the platform driver was applying option values if any option had changed, resulting in several getting overwritten

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 4c08bcc
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/667b4b97ca203b00087819e2

@heiko-braun heiko-braun merged commit bd5f15d into loft-sh:main Jun 26, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants