Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor resource host to virtual mappings #1925

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

FabianKramm
Copy link
Member

@FabianKramm FabianKramm commented Jul 12, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

Please provide a short message that should be published in the vcluster release notes
Refactors the way vCluster maps virtual name to host names. This allows us to implement more flexible ways of rewritting names:

  • Introduces a mapper per GVK to map virtual name to host name and back
  • Allows globally accessing these mappers so that syncer can rewrite names used by other mappers this way
  • Refactors all controllers to use the mappers instead of the internal mapping functions
  • This will require changes to the vCluster SDK & Pro

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for vcluster-docs ready!

Name Link
🔨 Latest commit 26e62df
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6698c53dba0cbd00087ba8a5
😎 Deploy Preview https://deploy-preview-1925--vcluster-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@FabianKramm FabianKramm force-pushed the mappings branch 9 times, most recently from ab004a8 to 28b729e Compare July 15, 2024 18:22
@FabianKramm FabianKramm force-pushed the mappings branch 11 times, most recently from efd2428 to 97b510b Compare July 17, 2024 14:00
@FabianKramm FabianKramm changed the title DRAFT: Refactor resource mappings refactor resource mappings Jul 17, 2024
@FabianKramm FabianKramm changed the title refactor resource mappings refactor resource host to virtual mappings Jul 17, 2024
pkg/controllers/resources/events/syncer.go Show resolved Hide resolved
pkg/controllers/resources/events/syncer.go Show resolved Hide resolved
pkg/controllers/resources/persistentvolumes/translate.go Outdated Show resolved Hide resolved
pkg/mappings/types.go Outdated Show resolved Hide resolved
pkg/mappings/types.go Outdated Show resolved Hide resolved
pkg/setup/managers.go Outdated Show resolved Hide resolved
pkg/setup/managers.go Outdated Show resolved Hide resolved
@FabianKramm FabianKramm merged commit c082311 into loft-sh:main Jul 18, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants