Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: combine IsManaged & IsManagedCluster #1951

Merged
merged 2 commits into from
Jul 18, 2024
Merged

refactor: combine IsManaged & IsManagedCluster #1951

merged 2 commits into from
Jul 18, 2024

Conversation

FabianKramm
Copy link
Member

@FabianKramm FabianKramm commented Jul 18, 2024 •
edited
Loading

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

PR Changes:

  • Combine IsManaged & IsManagedCluster
  • Get rid of LegacyTargetNamespace()
  • Move IsManaged into mapper so that we can centrally control what objects should be managed by vCluster

@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit b5b31d6
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6699069b980d4400085d21d6

@FabianKramm FabianKramm merged commit 3f5188d into loft-sh:main Jul 18, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchettos facchettos facchettos approved these changes

@ThomasK33 ThomasK33 ThomasK33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabianKramm @ThomasK33 @facchettos