added patch logic for services #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
FabianKramm
reviewed
Jul 19, 2024
| } | ||
|
|
||
| return ctrl.Result{Requeue: true}, nil | ||
| return ctrl.Result{Requeue: true}, err |
There was a problem hiding this comment.
This should go after line 98
There was a problem hiding this comment.
tests are failing if I move it there
facchettos
force-pushed
the
service-patcher
branch
from
931d20a
to
175c2ff
Compare
facchettos
commented
Jul 19, 2024
facchettos
commented
Jul 19, 2024
FabianKramm
force-pushed
the
service-patcher
branch
from
05aec0e
to
d982b9c
Compare
FabianKramm
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)part of eng-4141
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?