fix: order of volumesnapshot syncers #1965

FabianKramm · 2024-07-19T13:00:49Z

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

Moved CRD creation into the mapper as the index for the mappers are called before the Init function for controllers was called. To avoid confusion the Initializer function was removed as well.

netlify · 2024-07-19T13:01:15Z

✅ Deploy Preview for vcluster-docs canceled.

Name	Link
🔨 Latest commit	`94a1c24`
🔍 Latest deploy log	https://app.netlify.com/sites/vcluster-docs/deploys/669a6c5b8e31b1000857099e

pkg/mappings/resources/volumesnapshotcontents.go

pkg/mappings/resources/volumesnapshotclasses.go

pkg/patcher/patcher.go

pkg/util/crds.go

facchettos · 2024-07-19T13:29:52Z

pkg/controllers/syncer/testing/manager.go

@@ -30,7 +30,7 @@ type fakeManager struct {

 func (f *fakeManager) SetFields(interface{}) error { return nil }

-func (f *fakeManager) GetConfig() *rest.Config { return &rest.Config{Host: "127.0.0.1"} }
+func (f *fakeManager) GetConfig() *rest.Config { return &rest.Config{Host: "unit-test-client"} }


is it still used?

I think this actually is still a good idea as this shows up in tests a lot nicer than 127.0.0.1

FabianKramm force-pushed the pv-vsc-syncer branch from 8dbf205 to 876d37b Compare July 19, 2024 13:02