refactor: move mappings into register context #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
FabianKramm
force-pushed
the
pv-vsc-syncer
branch
4 times, most recently
from
0ae47bf
to
46cac24
Compare
facchettos
reviewed
Jul 22, 2024
pkg/controllers/resources/persistentvolumes/fake_syncer_test.go
Outdated
Show resolved
Hide resolved
FabianKramm
force-pushed
the
pv-vsc-syncer
branch
from
46cac24
to
5ab058c
Compare
FabianKramm
force-pushed
the
pv-vsc-syncer
branch
from
5ab058c
to
a412db3
Compare
facchettos
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
Please provide a short message that should be published in the vcluster release notes
Moves the mappings store into the controller / register / syncer context instead of exposing it globally which allows for more control and separate mapping stores