Sleep wake cli #1983
Merged
Sleep wake cli #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
lizardruss
requested changes
Jul 24, 2024
facchettos
reviewed
Jul 29, 2024
facchettos
reviewed
Jul 29, 2024
facchettos
reviewed
Jul 29, 2024
facchettos
reviewed
Jul 29, 2024
lizardruss
requested changes
Jul 29, 2024
…rrect commands to wake it up Warns allows waking and adding a sleeping helm vcluster in a single command. Adds the ability to set chart dir for local dev when adding external cluster. Only errors if helm driver is specified, otherwise it falls back to a platform resume. Remove old check due to platform's auto conversion of helm slept clusters. Continue with adding the secret in either case and only add if they choose to wake the cluster. Co-authored-by: Russell Centanni <russell.centanni@gmail.com>
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #ENG-4157
resolves #ENG-4158
resolves #ENG-4159
Please provide a short message that should be published in the vcluster release notes
Sleep and wake features used across drivers (platform/helm) are more intelligent when the
--driverflag is omitted, still providing useful information for failures if the wrong driver is explicitly used from the command.