Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] moved login from root level to platform subcommand #2034

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

facchettos
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-4288

Please provide a short message that should be published in the vcluster release notes
deprecated vcluster login in favor of vcluster platform login

What else do we need to know?

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ba5ed4
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66b38cac543ae30008d9796b

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not move the login/logout functionality to the platform cmd/platform package and then reuse the RunLogin / RunLogout instead of copying over the functions completely?

@facchettos facchettos force-pushed the login-deprecate branch 3 times, most recently from e32d108 to 39137d2 Compare August 7, 2024 14:47
@facchettos facchettos added the backport-to-v0.20 backport this PR to v0.20 branch label Aug 7, 2024
@FabianKramm FabianKramm merged commit f6c1ae2 into loft-sh:main Aug 8, 2024
62 checks passed
@loft-bot
Copy link

loft-bot commented Aug 8, 2024

💚 All backports created successfully

Status Branch Result
v0.20

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

FabianKramm added a commit that referenced this pull request Aug 8, 2024
[v0.20] Merge pull request #2034 from facchettos/login-deprecate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.20 backport this PR to v0.20 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants